fix inc/dec operator with DecimalField + improve its doc #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bagerard This is very educational PR. But, you ci fails with style error. |
|
argh, let me fix that |
|
roar me when you fix :) @bagerard |
|
In fact it complains about I've only added 2 lines there... Sounds like that method was forced through the CI at some point (or the check wasn't there back in the days). I can have a look to refactor that method but its a central piece of code in the application so its quite risky. I don't think its a good solution to do this as part of this PR |
|
try to rebase master into your branch. I merged the fix |
bagerard
force-pushed
the
inc_operator_with_decimal
branch
from
233cf30 to
ab08e67
Compare
|
Let's see now |
|
it's green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes inc/dec operators when using DecimalField + improve the doc and emphasize important problems of the DecimalField as it is implemented (#637)
Fixes #1517
Fixes #1320