Fixed ListField deletion bug. #1318

[JohnAD]

Fixes #1318

The BaseList supported the delitem operator in a manner
similar to DictList, however the key to a list is an index rather
than unique key. MongoDB does not support pulling from an array
by index; therefore the entire list must be marked as changed.
MongoDB reference: https://jira.mongodb.org/browse/SERVER-1014

[wojcikstefan]

Thanks for this @JohnAD! Could you add a unit test and confirm it fails w/o your patch?

[wojcikstefan]

@JohnAD I think you need to rebase against the latest master.

[JohnAD]

I will rebase. In fact, if you are okay with it, I would like to add comprehensive tests for all relevant list operators (other than those being tested already). I'll probably label the functions test_list_field_manipulative_operators and test_list_field_lexographic_operators. It will delay things only by a day or so.

[wojcikstefan]

Sounds great! The more coverage the better :)

…

On Thu, Dec 15, 2016 at 12:34 AM John Dupuy ***@***.***> wrote: I will rebase and add the unittest code. In fact, if you are okay with I, I would like to add comprehensive tests for all relevant list operators (other than those being tested already). I'll probably label the functions test_list_field_manipulative_operators and test_list_field_lexographic_operators. It will delay things only by a day or so. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1435 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABo4ZPCEa91d0gCy1XLMxLhz6hQw5KWlks5rINFWgaJpZM4LLD_V> .

[JohnAD]

Should be ready.

[wojcikstefan]

Thank you @JohnAD. The diff still shows code changes unrelated to this PR. Can you rebase against the upstream master?

[JohnAD]

That is odd. Did another rebase from master of this repo. Is it clean now?

[wojcikstefan]

Yup, still an issue. Do you see the same commit history I'm seeing?

Try this:

1. git remote add upstream [email protected]:MongoEngine/mongoengine.git
2. git fetch upstream
3. git rebase upstream/master
4. Manage any conflicts that arise.

[JohnAD]

That is, IIRC, how I did the rebase with upstream. This time, I actually encountered circular merge conflicts on the very changes that I made. Odd. This time I did a git push origin --force when finished to see if I can clean up the head.

[wojcikstefan]

This is great! Thank you for a comprehensive set of tests and for all the back-and-forths @JohnAD !