Fix iteration within iteration #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2016
Closed
|
@touilleMan are you still involved with this project? If so, would you mind reviewing this? I noticed that you gave a thoughtful description of the problem in #1086 (comment). |
|
@wojcikstefan I'm not very active on the project right now (working on my own mongo odm 😛 ) but I always love to give a hand ! The PR pretty elegant to me, it's all good 👍 |
|
Thanks @touilleMan! I want to check out umongo for my next project, but for now I'll just try to make MongoEngine faster and less buggy :) |
|
Nice, happy to see this fixed finally! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these fixes, iterating over a queryset within another iteration would cause the "outer" iteration to only return 100 results.
This PR also fixes #1086 where calling
len(qs)mid-iteration would cause the same problem.Thanks to @eli-b and @gordol for inspiration!