Import error fix for 0.8.x with Django 1.9

[apolkosnik-old]

With more recent versions of Django (1.9+) we get this error:

File "/Library/Python/2.7/site-packages/mongoengine/django/mongo_auth/models.py", line 6, in

from django.utils.importlib import import_module

ImportError: No module named importlib

I was able to change the import statement to the following to alleviate that issue:

from importlib import import_module

[lafrech]

Related to #872

Is 0.8 still maintained?

0.8 branch is far from latest 0.8 release.

How shall we proceed? Forward 0.8 branch to 0.8.8 tag, then add this fix, then release 0.8.9?

[lafrech]

@frbapolkosnik, anything preventing you from moving to ME 0.9 or 0.10?

[apolkosnik-old]

I'm working on getting my apps to 0.10.x (at this point, I'm trying to get other things like django- tastypie-mongoengine fixed, asking for django_mongoengine to get a next release onto PyPI, and things like that...), but 0.8.9 would be great to allow people more time to figure out the upgrade path (if not just allowing to upgrade their Django to something more recent).

Thank you!

[lafrech]

I'm a bit uncertain about 0.8.x development. There was a 0.8.8 release, but the 0.8 branch is outdated so I don't know in which state the 0.8.x development is. I mean we could start from 0.8.8 and add the fix and release as 0.8.9, but I'd like to be sure we wouldn't lose post-0.8.8-but-yet-unreleased work.

I'm pretty sure we could do that, but I'd rather have @thedrow or @touilleMan's validation.

If they confirm, maybe you can branch from 0.8.8, patch with the fix you need, then submit a PR onto 0.8 branch.

[lafrech]

While updating the changelog for 0.8.9, we may also add a note about 0.8.8. Explanations about it here: #944.

[lafrech]

It's probably safe to do as I said.

@frbapolkosnik,I think you can

• branch from 0.8.8
• patch with said fix
• submit PR onto 0.8 branch

And we'll be able to release a 0.8.9 which will be 0.8.8 + the fix.

(And we'll have 0.8 branch synced with latest 0.8.x release, which is not the case currently.)

[apolkosnik-old]

I hope that #1261 will do.

[apolkosnik-old]

Whoops.

[apolkosnik-old]

ok, fixed the typo.

[wojcikstefan]

This seems to pertain to v0.8.x and we're already on v0.10.7 (https://github.com/MongoEngine/mongoengine/releases/tag/v0.10.7). It this is still an issue in the latest release, let us know please @apolkosnik-old.

[apolkosnik]

It was a stupid simple fix pertaining to 0.8.8, because 0.10.x just kills the performance among other things... See marrow/contentment#12 for a quite large list.