Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Python 3.12 & 3.13 support #782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Python 3.12 & 3.13 support #782

wants to merge 1 commit into from

Conversation

bennybp
Copy link
Contributor

@bennybp bennybp commented Oct 25, 2023

Description

This PR makes the QCArchive packages 3.12 complient, and adds tests

Currently blocked by 3.12 support for geometric. See leeping/geomeTRIC#173 (see leeping/geomeTRIC#174 for progress)

Changelog description

Add support for python 3.12

Status

  • Code base linted
  • Ready to go

@bennybp bennybp force-pushed the py312 branch 2 times, most recently from 4bb0fc6 to f7a807c Compare March 20, 2024 22:25
@mattwthompson
Copy link
Contributor

It looks like the upstream compatibility fixes were merged and released but not yet in conda packages?

https://github.com/leeping/geomeTRIC/releases/tag/1.0.2

conda-forge/geometric-feedstock#16

@bennybp
Copy link
Contributor Author

bennybp commented Apr 4, 2024

Yes. Also, torsiondrive is not 3.12 compatible: lpwgroup/torsiondrive#78

@mattwthompson
Copy link
Contributor

Okay, I have the build issues fixed: conda-forge/geometric-feedstock#17

@mattwthompson
Copy link
Contributor

The geomeTRIC 1.0.2 builds are online, I believe this is still blocked by a TorsionDrive release (and builds)

@bennybp bennybp changed the title [WIP] Python 3.12 support [WIP] Python 3.12 & 3.13 support Oct 21, 2024
@bennybp
Copy link
Contributor Author

bennybp commented Oct 21, 2024

Updated the title to include Python 3.13. I have talked to the torsiondrive/geometric folks (@hjnpark), and me and @Lnaden will work on anything holding back those releases.

The geometric release will need to be done for NEB support, but should otherwise be python 3.13 ready. Torsiondrive I think should work, but needs testing.

Torsiondrive seems to be using Travis still, so we can discuss moving that to GHA. No one is currently actively maintaining torsiondrive at the moment from what we can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants