Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more scrap whitelist to toolbox #2535

Conversation

Hmeister-real
Copy link

@Hmeister-real Hmeister-real commented May 20, 2024

About The Pull Request

Someone told me wyci when i asked in ooc, so i did! Adds more whitelist for scrap and other materials to the toolbox, Scavs rejoice!

Why It's Good For The Game

Makes toolbox more useful, alternative to carrying a second backpack for scrap

Changelog

🆑 Hmeister
qol: Toolboxes now have a less strict whitelist and hold most scraps and junk.

@Hmeister-real
Copy link
Author

idk why it's failing, nothings wrong. probably a MS Git thing

@ProfessorPopoff
Copy link
Contributor

Yeah- checks are a bit wonky right now.

We actually do have some errors in regards to the toolboxes. I don't have them handy right now but there's runtimes on init.

That being said, I think better implementation of this would actually be removing the whitelist entirely and just letting people use the container for what it is- a container.

The only container i'd really like to continue this way is maybe the doctor's bag/medical kits because those are usually pretty specifically built inside with all sorts of pockets and straps and whatnot- Plus it wouldn't hurt to have /some/ specialty.

Though on a more soul-bound train of thought: Tools are only half of what goes into my toolbox IRL lol.

tldr: Nuke toolbox whitelists

@Hmeister-real
Copy link
Author

tldr: Nuke toolbox whitelists

thought that would have been a little too drastic, but looking in retrospect would make more sense, il close this and make a different PR to nuke a few whitelists

@Hmeister-real Hmeister-real deleted the attempt-2,-not-to-fucking-master-this-time branch May 22, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants