Skip to content

Commit

Permalink
fix(github): remove redundant diagnostics
Browse files Browse the repository at this point in the history
  • Loading branch information
MoLow committed Feb 28, 2023
1 parent 04ceb1b commit b62df32
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
3 changes: 2 additions & 1 deletion packages/github/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,10 @@ module.exports = async function githubReporter(source) {
counter.fail += 1;
break;
} case 'test:diagnostic':
core.notice(event.data.message, { file: getFilePath(event.data.file) });
if (event.data.nesting === 0) {
diagnostics.push(event.data.message);
} else {
core.notice(event.data.message, { file: getFilePath(event.data.file) });
}
break;
default:
Expand Down
7 changes: 0 additions & 7 deletions packages/github/tests/output.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,6 @@ module.exports = {
::debug::starting to run fails
::error title=fails,file=tests/example.js::\\[Error \\[ERR_TEST_FAILURE\\]: this is an error\\] {%0A failureType: 'testCodeFailure',%0A cause: Error: this is an error%0A at Object.<anonymous> (.*/example.js:6:11).*
::error title=tests,file=tests/example.js::\\[Error \\[ERR_TEST_FAILURE\\]: 1 subtest failed\\] { failureType: 'subtestsFailed', cause: '1 subtest failed', code: 'ERR_TEST_FAILURE' }
::notice file=tests/example.js::tests 1
::notice file=tests/example.js::pass 0
::notice file=tests/example.js::fail 1
::notice file=tests/example.js::cancelled 0
::notice file=tests/example.js::skipped 0
::notice file=tests/example.js::todo 0
::notice file=tests/example.js::duration_ms .*
::group::Test results \\(1 passed, 2 failed\\)
::notice::Total Tests: 1%0APassed ✅: 0%0AFailed ❌: 1%0ACanceled 🚫: 0%0ASkipped ⏭️: 0%0ATodo 📝: 0%0ADuration: .*ms
::endgroup::
Expand Down

0 comments on commit b62df32

Please sign in to comment.