Fix null ref in SpatialManipulationReticle when multiple interactables are hovered #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
shaynie
requested changes
Jul 24, 2024
org.mixedrealitytoolkit.spatialmanipulation/BoundsControl/Visuals/SpatialManipulationReticle.cs
Show resolved
Hide resolved
shaynie
approved these changes
Jul 24, 2024
AMollis
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671
Ensures that we actually pass a
BoundsHandleInteractabletoRotateReticle, as that's what it's expecting as far as hierarchy. If we inadvertently pass theBoundsControl, the hierarchy logic is incorrect (no parent when it's in the root of the scene).This case won't be hit in the default MRTK XR Rig. It's only when "Hit Closest Only" on a ray interactor is unchecked that this case is possible.