Don't change input simulation gesture state unless momentarily toggled #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
|
@keveleigh MRTK Mondays is happening! |
AMollis
added
the
Package: Input
AMollis
requested changes
Mar 25, 2024
org.mixedrealitytoolkit.input/Editor/Inspectors/EyeGazeSimulationSettingsDrawer.cs
Outdated
Show resolved
Hide resolved
Oops, yup! |
keveleigh
force-pushed
the
don't-change-gesture-state-unless-momentarily-toggled
branch
2 times, most recently
from
a9e4068 to
7b7f1c3
Compare
keveleigh
force-pushed
the
don't-change-gesture-state-unless-momentarily-toggled
branch
from
7b7f1c3 to
94cd9c4
Compare
AMollis
approved these changes
Mar 27, 2024
AMollis
requested changes
Mar 27, 2024
MaxPalmer-UH
reviewed
Apr 9, 2024
keveleigh
force-pushed
the
don't-change-gesture-state-unless-momentarily-toggled
branch
from
78b374d to
12e72eb
Compare
AMollis
previously approved these changes
Apr 25, 2024
david-c-kline
approved these changes
May 8, 2024
keveleigh
deleted the
don't-change-gesture-state-unless-momentarily-toggled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #594
Changes the update logic to only handle button presses, etc if the simulated input is momentarily toggled instead of permanently toggled.
Also fixes this UI overlap:
Two_Handed_Simulation.mp4