Adding Rigidbody MovementType to ObjectManipulator #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whebertML
added
Type: Feature Request
whebertML
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
5 tasks
whebertML
force-pushed
the
movementType
branch
from
e48b0e9 to
2a8a5c1
Compare
whebertML
commented
Nov 8, 2023
org.mixedrealitytoolkit.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Show resolved
Hide resolved
AMollis
requested changes
Nov 9, 2023
org.mixedrealitytoolkit.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Outdated
Show resolved
Hide resolved
org.mixedrealitytoolkit.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Outdated
Show resolved
Hide resolved
org.mixedrealitytoolkit.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Show resolved
Hide resolved
org.mixedrealitytoolkit.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Outdated
Show resolved
Hide resolved
org.mixedrealitytoolkit.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Outdated
Show resolved
Hide resolved
org.mixedrealitytoolkit.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Show resolved
Hide resolved
org.mixedrealitytoolkit.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Outdated
Show resolved
Hide resolved
|
Thanks for the review @AMollis! Have a couple of fires internally, but will update and respond soon as I can. |
whebertML
force-pushed
the
movementType
branch
from
6739b5e to
60b4369
Compare
AMollis
requested changes
Nov 13, 2023
org.mixedrealitytoolkit.spatialmanipulation/ObjectManipulator/ObjectManipulator.cs
Show resolved
Hide resolved
* Added XRBaseInteractable.MovementType to ObjectManipulator so devs can specify the movement type of the rigid body during manipulation. * Observes XRBaseInteractor.selectedInteractableMovementTypeOverride
whebertML
force-pushed
the
movementType
branch
from
032b08f to
f39b34a
Compare
AMollis
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds XRI's XRBaseInteractable.MovementType to ObjectManipulator so devs can specify the movement type of the rigid body during manipulation.
Currently the behavior always forces non-kinematic "Velocity Tracking" when a rigid body is attached, setting velocity and angular velocity to move the rigid body. This would allow the dev to specify other types of movement, like kinematic, as is provided in XRI. This also observes the XRBaseInteractor.selectedInteractableMovementTypeOverride when an interactor overrides the movement type.
Resolves: #532
Related to being more compatible with XRI #67