Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the clear color on MRTK's default rig (should be clearing with a 0 alpha) #517

Merged

Conversation

AMollis
Copy link
Contributor

@AMollis AMollis commented Oct 18, 2023

A camera clear color with an alpha value of non-zero will show-up on HoloLens's Mixed Reality Capture videos.

Fixes:

@AMollis AMollis requested review from marlenaklein-msft, shaynie and a team as code owners October 18, 2023 20:31
@AMollis AMollis added the Package: Input The Project input package is impacted by this issue. label Oct 18, 2023
@AMollis AMollis self-assigned this Oct 18, 2023
@AMollis AMollis requested a review from keveleigh October 18, 2023 20:32
@AMollis AMollis enabled auto-merge (squash) October 18, 2023 20:50
Copy link
Contributor

@keveleigh keveleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! Looks like it'll match the rig's camera's existing default with this change.

@whebertML
Copy link
Contributor

This is an issue on our device as well and has to be set to 0 to get good captures in certain scenarios. Welcome change of defaults!!

@AMollis AMollis merged commit fdb158c into MixedRealityToolkit:main Oct 19, 2023
4 checks passed
@AMollis AMollis added the Type: Bug A problem with an existing feature that can be fixed with the next patched release. label Nov 3, 2023
@AMollis AMollis deleted the user/amollis/main/fix-clear-color branch January 29, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Input The Project input package is impacted by this issue. Type: Bug A problem with an existing feature that can be fixed with the next patched release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants