-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Precompile Statements to Prevent Warnings in Unity 2023 (Refactored) #515
Merged
marlenaklein-msft
merged 6 commits into
MixedRealityToolkit:main
from
marlenaklein-msft:refactorIfDefs
Oct 18, 2023
Merged
Add Precompile Statements to Prevent Warnings in Unity 2023 (Refactored) #515
marlenaklein-msft
merged 6 commits into
MixedRealityToolkit:main
from
marlenaklein-msft:refactorIfDefs
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenaklein-msft
requested review from
AMollis,
shaynie and
a team
as code owners
October 18, 2023 18:31
AMollis
previously approved these changes
Oct 18, 2023
AMollis
added
Package: Core
The Project core package is impacted by this issue.
Package: Input
The Project input package is impacted by this issue.
Package: Spatial Manipulation
The Project spatial manipulation package is impacted by this issue.
Package: UX Components
The Project ux components package is impacted by this issue.
Package: UX Components (Non-Canvas)
The Project ux component (non-canvas) package is impacted by this issue.
Package: UX Core
The Project ux core package is impacted by this issue.
labels
Oct 18, 2023
AMollis
previously approved these changes
Oct 18, 2023
keveleigh
requested changes
Oct 18, 2023
org.mixedrealitytoolkit.input/InteractionModes/InteractionModeManager.cs
Outdated
Show resolved
Hide resolved
keveleigh
approved these changes
Oct 18, 2023
AMollis
added
the
Type: Bug
A problem with an existing feature that can be fixed with the next patched release.
label
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Package: Core
The Project core package is impacted by this issue.
Package: Input
The Project input package is impacted by this issue.
Package: Spatial Manipulation
The Project spatial manipulation package is impacted by this issue.
Package: UX Components (Non-Canvas)
The Project ux component (non-canvas) package is impacted by this issue.
Package: UX Components
The Project ux components package is impacted by this issue.
Package: UX Core
The Project ux core package is impacted by this issue.
Type: Bug
A problem with an existing feature that can be fixed with the next patched release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @keveleigh's suggestion to refactor this PR #506.
FIxes: