#776 fix for libmysqlclient.so.18 error when using slim_handler

[timj98]

Added include to zappa_settings
Added ctypes to handler to load the selected libraries directly to
PYTHONPATH

Description

This PR fixes the issue where Django using MySQLdb looks for libmysqlclient.so.18 and could not find it in any path when using the slim_handler. I creates a setting in the zappa_settings file for the specific library to add at handler init.

GitHub Issues

#776

[coveralls]

Coverage decreased (-63.3%) to 15.81% when pulling 59b7e66 on timj98:master into 08bed45 on Miserlou:master.

[coveralls]

Coverage decreased (-0.3%) to 78.873% when pulling 0bbf12d on timj98:master into 08bed45 on Miserlou:master.

[Miserlou]

Okay, this looks like we're on the right track.

Two things:

1. Can we include some sane defaults for INCLUDE so that MySQL and others affected by this in lambda-packages all work out of the box?

2. Please change the print statements to print() so that we don't have to update them when P3 drops.

[timj98]

That make sense, I’ll add those tonight. I will include the defaults for MySQL-Python and mysqlclient. I was concerned about the coveralls test and resultant reduction in coverage. TimJ

…

On Apr 14, 2017, at 12:18 PM, Rich Jones ***@***.***> wrote: Okay, this looks like we're on the right track. Two things: Can we include some sane defaults for INCLUDE so that MySQL and others affected by this in lambda-packages all work out of the box? Please change the print statements to print() so that we don't have to update them when P3 drops. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#789 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvUMxvysR9Pnq1pcBDnBOws6_32gaF2ks5rv6pYgaJpZM4M9FCl>.

[coveralls]

Coverage decreased (-0.3%) to 78.851% when pulling 815964d on timj98:master into 6e6fc19 on Miserlou:master.

[Miserlou]

I've merged this in now, thank you for going in on this!

Just as a style point, you included a line of exceptionally ugly code:

settings_s += "INCLUDE=[" + ','.join(("'","'")).join(self.stage_config.get('include', [])).join(("'","'")) + "]\n"

Since it's already a list, we can simply cast it to a string:

include = self.stage_config.get('include', [])
if len(include) >= 1:
    settings_s += "INCLUDE=" + str(include) + '\n'

I've gone ahead and changed this already, but in future it's generally good to try to keep the code as short, readable and WTF-free as possible!

Thanks again,
R

[timj98]

Thanks. I appreciate the opportunity and the feedback. TimJ

…

On Apr 16, 2017, at 1:41 PM, Rich Jones ***@***.***> wrote: I've merged this in now, thank you for going in on this! Just as a style point, you included a line of exceptionally ugly code: settings_s += "INCLUDE=[" + ','.join(("'","'")).join(self.stage_config.get('include', [])).join(("'","'")) + "]\n" Since it's already a list, we can simply cast it to a string: include = self.stage_config.get('include', []) if len(include) >= 1: settings_s += "INCLUDE=" = str(include) + '\n' I've gone ahead and changed this already, but in future it's generally good to try to keep the code as short, readable and WTF-free as possible! Thanks again, R — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.