Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exercise for stratigraphic column and a sceintific task. #82

Merged
merged 14 commits into from
Nov 13, 2024
Merged

Conversation

xyl96
Copy link
Contributor

@xyl96 xyl96 commented Nov 11, 2024

updated notbook

…ok; add bibliography; other minor improvements
@xyl96
Copy link
Contributor Author

xyl96 commented Nov 12, 2024

I will try to make one possible solution for the task on Tuesday morning.

Copy link

@NiklasHohmann NiklasHohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better and clearer than before!

  • Specify where the model is actually run (code with "run_model")
  • Explain ALCAP, its not clear where this term comes from or what it stands for
  • Cell for plotting age-depth models: did not run out of the box, had to first disable and then enable the cell to make it work
  • Provide solution for empirical sea level exercise
  • Interactive exploration section: Visualization gave errors when initialized, errors disappeared when values were changed with the slider.
  • In this section, add context please. It is not clear that x and y represent positions in the platform! This must be explained in the text, and should also be shown in the title of the figures

@jhidding
Copy link
Member

jhidding commented Nov 12, 2024

Much better and clearer than before!

* Specify where the model is actually run (code with "run_model")

* Explain ALCAP, its not clear where this term comes from or what it stands for

* Cell for plotting age-depth models: did not run out of the box, had to first disable and then enable the cell to make it work

* Provide solution for empirical sea level exercise

* Interactive exploration section: Visualization gave errors when initialized, errors disappeared when values were changed with the slider.

* In this section, add context please. It is not clear that x and y represent positions in the platform! This must be explained in the text, and should also be shown in the title of the figures

I'll pick this up.

In reverse of your points:

  • check
  • The interactive visualization failed because the model hadn't run yet. I want to update the run_model function to return the output filename. This seems trivial, but it will allow Pluto to track the dependency between writing to the file and reading it again. Changes like this require a new release of CarboKitten, so I'm saving them up until wednesday.
  • The solution is actually in the documentation of CarboKitten. I don't want to spoil the solution in the notebook. I can put it in a <details> tag, and we'll ask the participants not to look before trying to solve themselves.
  • This is an issue with Pluto, which we're not going to fix
  • check
  • check

@EmiliaJarochowska
Copy link
Member

When a cross section is produced, it is not clear where in the grid it is located and how to change the location

Some people might also be interested in plotting along the shore, how difficult would that be?

@EmiliaJarochowska
Copy link
Member

Explain ALCAP, its not clear where this term comes from or what it stands for

I think @jhidding indicated this as done but I don't see the explanation

@jhidding
Copy link
Member

Sorry, no, just "check" that I agree and will implement.

@jhidding
Copy link
Member

Some people might also be interested in plotting along the shore, how difficult would that be?

Not very difficult, but I've never tried.

@EmiliaJarochowska
Copy link
Member

EmiliaJarochowska commented Nov 12, 2024

Updated feedback from Niklas and myself (played with it live):

  • Explanations of the summary plot are duplicated
  • on the sinusoid SL plot units are wrong on the y axis
  • what does write_times do?
  • the dot operator in plotting the SL function may be incomprehensible but don't add another box about julia syntax, maybe just an inline comment?
  • Bosscher & Schlager 92 and Burgess 13 should be in references (maybe @xyl96 could take care of that?)
  • in ADM and strat column plots, locations should be labeled based on the distance from the shore

Copy link
Member

@jhidding jhidding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra files need to go away. Put them in a separate branch, and document it in a case file (next to the tabular sea level chapter). Make sure to use Entangled.

examples/model/alcap/plot.jl Outdated Show resolved Hide resolved
examples/model/alcap/run.jl Outdated Show resolved Hide resolved
@xyl96
Copy link
Contributor Author

xyl96 commented Nov 12, 2024

In this case, it exports the 11th, 26th and 41th grid in the direction towards to the deep sea. That is to say, the 11th is proximal to the land while the 41th is distal. Given that each grid is with fixed size of 150 m × 150 m, this indicates that we are extracting information from locations at 3 km, 7.5 km and 12 km away from the land.

This bit we need to renew the location distance. I will do it later.

@jhidding
Copy link
Member

In this case, it exports the 11th, 26th and 41th grid in the direction towards to the deep sea. That is to say, the 11th is proximal to the land while the 41th is distal. Given that each grid is with fixed size of 150 m × 150 m, this indicates that we are extracting information from locations at 3 km, 7.5 km and 12 km away from the land.

This bit we need to renew the location distance. I will do it later.

No, the scale is 300 m, I don't know how it changed back to 150. The other numbers are correct.

@jhidding jhidding merged commit 937b311 into main Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants