-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exercise for stratigraphic column and a sceintific task. #82
Conversation
…ok; add bibliography; other minor improvements
I will try to make one possible solution for the task on Tuesday morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better and clearer than before!
- Specify where the model is actually run (code with "run_model")
- Explain ALCAP, its not clear where this term comes from or what it stands for
- Cell for plotting age-depth models: did not run out of the box, had to first disable and then enable the cell to make it work
- Provide solution for empirical sea level exercise
- Interactive exploration section: Visualization gave errors when initialized, errors disappeared when values were changed with the slider.
- In this section, add context please. It is not clear that x and y represent positions in the platform! This must be explained in the text, and should also be shown in the title of the figures
I'll pick this up. In reverse of your points:
|
When a cross section is produced, it is not clear where in the grid it is located and how to change the location Some people might also be interested in plotting along the shore, how difficult would that be? |
I think @jhidding indicated this as done but I don't see the explanation |
Sorry, no, just "check" that I agree and will implement. |
Not very difficult, but I've never tried. |
Updated feedback from Niklas and myself (played with it live):
|
…ion; explain some more about interactive plots; rework citations
To avoid merging issue, it is now not in notebook.
… significantly, not sure if this is better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra files need to go away. Put them in a separate branch, and document it in a case file (next to the tabular sea level chapter). Make sure to use Entangled.
This reverts commit d6ba898.
This bit we need to renew the location distance. I will do it later. |
No, the scale is 300 m, I don't know how it changed back to 150. The other numbers are correct. |
updated notbook