Skip to content

Commit

Permalink
Merge pull request opendatahub-io#134 from MichaelClifford/fix-131
Browse files Browse the repository at this point in the history
fix: use separate model checkpoint directories for each training phase
  • Loading branch information
sallyom authored Oct 30, 2024
2 parents 0fc76f3 + 0c947e1 commit e5a5323
Show file tree
Hide file tree
Showing 3 changed files with 139 additions and 139 deletions.
8 changes: 4 additions & 4 deletions pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def pipeline(
###

models_list_2_task = list_models_in_directory_op(
models_folder="/output/model/model/hf_format",
models_folder="/output/phase_2/model/hf_format",
)
models_list_2_task.set_caching_options(False)

Expand All @@ -324,7 +324,7 @@ def pipeline(
mount_pvc(
task=models_list_2_task,
pvc_name=output_pvc_task.output,
mount_path="/output/model",
mount_path="/output",
)

###
Expand All @@ -333,7 +333,7 @@ def pipeline(

run_mt_bench_task = run_mt_bench_op(
models_list=models_list_2_task.output,
models_path_prefix="/output/model/hf_format",
models_path_prefix="/output/phase_2/model/hf_format",
max_workers=max_workers,
merge_system_user_message=merge_system_user_message,
device=device,
Expand All @@ -360,7 +360,7 @@ def pipeline(
use_secret_as_env(run_mt_bench_task, JUDGE_SECRET, {"api_key": "JUDGE_API_KEY"})

final_eval_task = run_final_eval_op(
candidate_model="/output/model/hf_format/candidate_model",
candidate_model="/output/phase_2/model/hf_format/candidate_model",
taxonomy=git_clone_task.outputs["taxonomy"],
tasks=sdg_task.outputs["sdg"],
# TODO: DO we need both candidate_branch and base_branch
Expand Down
Loading

0 comments on commit e5a5323

Please sign in to comment.