Skip to content

Commit

Permalink
Merge pull request opendatahub-io#183 from MichaelClifford/fix-182
Browse files Browse the repository at this point in the history
fix: use RHELAI_IMAGE for data processing
  • Loading branch information
cooktheryan authored Nov 18, 2024
2 parents 7ab4cb9 + 25d781f commit ac474e1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
7 changes: 3 additions & 4 deletions pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -638,9 +638,8 @@ deploymentSpec:
- "\nif ! [ -x \"$(command -v pip)\" ]; then\n python3 -m ensurepip ||\
\ python3 -m ensurepip --user || apt-get install python3-pip\nfi\n\nPIP_DISABLE_PIP_VERSION_CHECK=1\
\ python3 -m pip install --quiet --no-warn-script-location 'kfp==2.10.0'\
\ '--no-deps' 'typing-extensions>=3.7.4,<5; python_version<\"3.9\"' &&\
\ python3 -m pip install --quiet --no-warn-script-location 'instructlab-training@git+https://github.com/instructlab/training.git'\
\ && \"$0\" \"$@\"\n"
\ '--no-deps' 'typing-extensions>=3.7.4,<5; python_version<\"3.9\"' && \"\
$0\" \"$@\"\n"
- sh
- -ec
- 'program_path=$(mktemp -d)
Expand Down Expand Up @@ -696,7 +695,7 @@ deploymentSpec:
\ max_seq_len=train_args.max_seq_len,\n chat_tmpl_path=train_args.chat_tmpl_path,\n\
\ )\n )\n\n data_processing(train_args=skill_training_args)\n\
\ data_processing(train_args=knowledge_training_args)\n\n"
image: registry.access.redhat.com/ubi9/python-311:latest
image: quay.io/redhat-et/ilab:1.2
exec-deletepvc:
container:
image: argostub/deletepvc
Expand Down
9 changes: 2 additions & 7 deletions training/components.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,10 @@

from kfp import dsl

from utils.consts import PYTHON_IMAGE, TOOLBOX_IMAGE
from utils.consts import PYTHON_IMAGE, RHELAI_IMAGE, TOOLBOX_IMAGE


@dsl.component(
base_image=PYTHON_IMAGE,
packages_to_install=[
"instructlab-training@git+https://github.com/instructlab/training.git"
],
)
@dsl.component(base_image=RHELAI_IMAGE)
def data_processing_op(
model_path: str = "/model",
sdg_path: str = "/data/sdg",
Expand Down

0 comments on commit ac474e1

Please sign in to comment.