feat: Fix --override-filename for flakes #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for flakes Closes Mic92#282
|
You can run the formatter by using the |
|
Thank you. I ended up running I was just confused with the |
|
@mergify queue |
🛑 The pull request has been merged manuallyThe pull request has been merged manually at cadf51a |
|
This pull request has been removed from the queue for the following reason: Pull request #301 has been dequeued. The pull request has been merged manually. The pull request has been merged manually at cadf51a. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #282
I ran
pytestand tested it for a package in a flake.I didn't test without flake as I don't know how to do that atm.
I'm a bit unsure with
self.version_position.file = self.filenameas I'm overwriting the filename unconditionally but if it wasn't passed by--override-filenamebut comes from the nix expression instead, it might not have the same source as theraw_version_positon(sanitizePosition (builtins.unsafeGetAttrPos "version" pkg)vs potentiallysanitizePosition (positionFromMeta pkg)orsanitizePosition (builtins.unsafeGetAttrPos "src" pkg)), which could break some other cases.Btw, how am I supposed to properly run the formatter for the repo? Maybe sth. to add to the dev instructions in the README?