Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: @metamask/providers@^13.1.0->^14.0.2 #21931

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 22, 2023

Description

  • deps: @metamask/providers@^13.1.0->^14.0.2
  • deps: extension-port-stream@^2.1.1->^3.0.0
  • deps: json-rpc-middleware-stream@^4.2.1->^5.0.1

This fully removes runtime dependency on @metamask/[email protected], except for @metamask/keyring-api (MetaMask/keyring-api#209)

Related issues

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@legobeat legobeat force-pushed the lgbt/deps-providers-14 branch from 39a4393 to a30f096 Compare November 22, 2023 09:40
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat force-pushed the lgbt/deps-providers-14 branch from a30f096 to 5437c80 Compare November 22, 2023 09:42
@legobeat legobeat changed the title deps: @metamask/providers@^13.1.0->^14.0.1 deps: @metamask/providers@^13.1.0->^14.0.2 Nov 22, 2023
@legobeat
Copy link
Contributor Author

@metamaskbot update-policies

@legobeat legobeat added team-security dependencies Pull requests that update a dependency file labels Nov 22, 2023
@metamaskbot
Copy link
Collaborator

Policies updated

@legobeat legobeat marked this pull request as ready for review November 22, 2023 09:53
@legobeat legobeat requested review from a team as code owners November 22, 2023 09:53
@legobeat legobeat force-pushed the lgbt/deps-providers-14 branch from d9e0c5b to 10d0484 Compare November 22, 2023 09:56
@legobeat
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@metamaskbot
Copy link
Collaborator

Builds ready [10d0484]
Page Load Metrics (491 ± 270 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8513796147
domContentLoaded6713384168
load791468491563270
domInteractive6713384168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -2.68 KiB (-0.07%)
  • ui: 0 Bytes (0.00%)
  • common: 146.12 KiB (3.20%)

@legobeat legobeat mentioned this pull request Nov 22, 2023
18 tasks
@FrederikBolding FrederikBolding merged commit 6f892d4 into develop Nov 22, 2023
69 of 70 checks passed
@FrederikBolding FrederikBolding deleted the lgbt/deps-providers-14 branch November 22, 2023 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
@metamaskbot metamaskbot added the release-11.7.0 Issue or pull request that will be included in release 11.7.0 label Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-11.7.0 Issue or pull request that will be included in release 11.7.0 team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants