Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: npm 9, lockfile version 3 #36

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 14, 2024

  • Upgrade package-lock.json schema from v1 to v3
  • NPM minimum version 9 (supported down to nodejs v14)

@legobeat legobeat requested a review from Gudahtt May 14, 2024 13:44
@legobeat
Copy link
Contributor Author

legobeat commented May 14, 2024

IMO this shouldn't need to be considered breaking as npm can be considered a dev dependency for this package.

Any CI environment building this on e.g. Debian 11, Ubuntu 20.04/22.04 using distribution Node.js will have to do a manual intervention - that's the sort of implication I could imagine there.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Member

Gudahtt commented May 15, 2024

IMO this shouldn't need to be considered breaking as npm can be considered a dev dependency for this package.

Agreed!

@legobeat legobeat merged commit d38f473 into MetaMask:master May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants