Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 270.0.0 #5058

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Release 270.0.0 #5058

merged 7 commits into from
Dec 11, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Dec 11, 2024

Explanation

Use the new Keyring API layout in related controllers. Some peer dependencies have been removed on the keyring-controller (but they remain here for the accounts-controller for now).

References

N/A

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly requested review from a team as code owners December 11, 2024 15:36
@ccharly ccharly force-pushed the release/270.0.0 branch 2 times, most recently from 188a62d to 0e124e2 Compare December 11, 2024 15:41
mcmire
mcmire previously requested changes Dec 11, 2024
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one comment about accounts-controller that blocks this PR.

packages/accounts-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/accounts-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
packages/chain-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/keyring-controller/CHANGELOG.md Outdated Show resolved Hide resolved
ccharly and others added 3 commits December 11, 2024 19:27
@mcmire mcmire dismissed their stale review December 11, 2024 18:43

Concerns addressed.

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good!

@ccharly ccharly enabled auto-merge (squash) December 11, 2024 18:44
ccharly added a commit that referenced this pull request Dec 11, 2024
…s) (#5061)

## Explanation

Found the same typo than last time, but on another section of the
CODEOWNERS.

Spotted while doing this release:
- #5058

## References

Similar to:
- #5029

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
@ccharly ccharly merged commit 5cba6b1 into main Dec 11, 2024
120 checks passed
@ccharly ccharly deleted the release/270.0.0 branch December 11, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants