-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Multichain API to @metamask/multichain
#4813
base: main
Are you sure you want to change the base?
Conversation
## Explanation This PR fixes a lot of the linting and typescript errors. still some left but this covers a lot of it. <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/package-a` - **<CATEGORY>**: Your change here - **<CATEGORY>**: Your change here ### `@metamask/package-b` - **<CATEGORY>**: Your change here - **<CATEGORY>**: Your change here ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Jiexi Luan <[email protected]>
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> Added ESM exports for multichain package ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/package-a` - **<CATEGORY>**: Your change here - **<CATEGORY>**: Your change here ### `@metamask/package-b` - **<CATEGORY>**: Your change here - **<CATEGORY>**: Your change here ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of my comments were minor. Surprisingly this was easier to review than the extension PR.
That said it wasn't clear to me how the middleware and subscription managers were intended to be used, perhaps it's worth adding some documentation for those or otherwise providing more context? I think that would help me review them better.
|
||
if (!caveat) { | ||
response.result = { sessionScopes: {} }; | ||
return end(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a dumb question, but I noticed — both here and in the extension PR — that we are calling end
explicitly. Isn't that an optional step in async middleware because it happens implicitly? (i.e. when a middleware throws an error, it end
s with that error, otherwise it just end
s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't really find consistent usage throughout the handler implementations I've seen. Not a dumb question at all! The middleware pipeline is flexible, and maybe it shouldn't be so flexible. Do you have a preferred approach/pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I assumed that handlers would always be used inside of async middleware, because if they were, we would be able to take advantage of the fact that async middleware don't require calling end
:
* Async middleware have no "end" function. Instead, they "end" if they return
* without calling "next". Rather than passing in explicit return handlers,
* async middleware can simply await "next", and perform operations on the
* response object when execution resumes.
Looking back at this, though, I see that 1) handlers aren't middleware themselves and 2) handlers can't assume that they are used inside of async middleware. Maybe when we refactor json-rpc-engine
to use async middleware everywhere we can simplify this, but it seems like we have to have the handlers take end
and call it manually.
packages/multichain/src/middlewares/multichainMethodCallValidator.test.ts
Outdated
Show resolved
Hide resolved
]; | ||
} | ||
// check each param and aggregate errors | ||
(methodToCheck as unknown as MethodObject).params.forEach((param) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above on line 51 we treated methodToCheck
as a ContentDescriptorObject
, now we treat it as a MethodObject
. Which one is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this to be MethodObject
e77e87f
packages/multichain/src/adapters/caip-permission-adapter-middleware.ts
Outdated
Show resolved
Hide resolved
…eware.ts Co-authored-by: Elliot Winkler <[email protected]>
…tor.test.ts Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
…eware.ts Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
…r.ts Co-authored-by: Elliot Winkler <[email protected]>
…tor.ts Co-authored-by: Elliot Winkler <[email protected]>
Explanation
This PR updates
@metamask/multichain
to add method handlers and middleware specific to the new Multichain API and which can be shared across the extension & mobile clients. The package includes implementations for managing multichain sessions, handling multichain RPC methods, and integrating multichain functionalities into the MetaMask extension. Key features of this package include:wallet_createSession
,wallet_invokeMethod
,wallet_revokeSession
, andwallet_getSession
.NormalizedScopesObject
andInternalScopesObject
These tools and utilities will be used in both clients (mobile + extension)'s multichain API implementations.
File Overview
packages/multichain/src/adapters/caip-permission-adapter-middleware.ts
: Middleware for the EIP-1193 API that enforces a CAIP-25 permission for each request if that CAIP-25 permission was granted viawallet_createSession
packages/multichain/src/handlers/wallet-getSession.ts
: Handlers for CAIP Multichain lifecycle methods except forwallet_createSession
which seemed a little too platform specific to belong in a shared package currentlypackages/multichain/src/middlewares/
: Middleware for the Multichain API that helps facilitate concurrent eth subscriptions and for using@metamask/api-specs
for method param validation for new CAIP Multichain methodspackages/multichain/src/scope/authorization.ts
: Adds helpers that sort scopes based on if they are currently supported by the wallet (i.e. a network already exists the eip155 scope), if they could be supported by the wallet (i.e. the network does not already exist for the eip155 scope, but the dapp has provided EIP-3085 details for adding the network in thescopedProperties
property of thewallet_createSession
request), or if they cannot be served.packages/multichain/src/scope/filter.ts
: provides helpers used for the bucketing above inauthorization.ts
types/@metamask/eth-json-rpc-filters.d.ts
: Typedef for missing types in@metamask/eth-json-rpc-filters/subscriptionManager
References
Upstream: #4784
Downstream: None. This is the end.
Key Multichain API Standards implemented here:
wallet_creatSession
wallet_invokeMethod
wallet_revokeSession
wallet_sessionChanged
wallet_getSession
Open PR that uses this new package for exposing the multichain API in the extension: MetaMask/metamask-extension#27782
Changelog
@metamask/multichain
getInternalScopesObject
andgetSessionScopes
helpers for transforming betweenNormalizedScopesObject
andInternalScopesObject
.caipPermissionAdapterMiddleware
for enforcing CAIP-25 permission on the EIP-1193 API.walletGetSession
,walletInvokeMethod
, andwalletRevokeSession
handlers.multichainMethodCallValidatorMiddleware
for validating Multichain API method params as defined in@metamask/api-specs
.MultichainMiddlewareManager
to multiplex a request to other middleware based on requested scope.MultichainSubscriptionManager
to handle concurrent subscriptions across multiple scopes.bucketScopes
which groups the scopes in aNormalizedScopesObject
based on if the scopes are already supported, could be supported, or are not supportable.getSupportedScopeObjects
helper for getting only the supported methods and notifications from eachNormalizedScopeObject
in aNormalizedScopesObject
.Checklist