Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keyring-api)!: add scopes field to KeyringAccount #101

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ccharly
Copy link
Collaborator

@ccharly ccharly commented Nov 22, 2024

@ccharly ccharly force-pushed the feat/keyring-account-scopes branch 2 times, most recently from 1bb66b2 to 22cd5fe Compare November 25, 2024 09:53
@ccharly
Copy link
Collaborator Author

ccharly commented Nov 25, 2024

@metamaskbot publish-previews

Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "11.0.0-22cd5fe",
  "@metamask-previews/eth-hd-keyring": "8.0.0-22cd5fe",
  "@metamask-previews/eth-ledger-bridge-keyring": "7.0.0-22cd5fe",
  "@metamask-previews/eth-simple-keyring": "8.0.0-22cd5fe",
  "@metamask-previews/eth-trezor-keyring": "6.0.0-22cd5fe",
  "@metamask-previews/eth-snap-keyring": "6.0.0-22cd5fe"
}

@ccharly ccharly force-pushed the feat/keyring-account-scopes branch from 22cd5fe to 7a50d54 Compare December 6, 2024 15:55
@ccharly ccharly force-pushed the feat/keyring-account-scopes branch from 7a50d54 to ab1eaab Compare December 9, 2024 10:24
@ccharly
Copy link
Collaborator Author

ccharly commented Dec 13, 2024

@metamaskbot publish-previews

Copy link

socket-security bot commented Dec 13, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@ccharly
Copy link
Collaborator Author

ccharly commented Dec 13, 2024

@metamaskbot publish-previews

Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "12.0.0-ac29af4",
  "@metamask-previews/eth-hd-keyring": "9.0.1-ac29af4",
  "@metamask-previews/eth-ledger-bridge-keyring": "8.0.1-ac29af4",
  "@metamask-previews/eth-simple-keyring": "8.0.1-ac29af4",
  "@metamask-previews/eth-trezor-keyring": "6.0.1-ac29af4",
  "@metamask-previews/keyring-internal-api": "1.0.0-ac29af4",
  "@metamask-previews/keyring-internal-snap-client": "1.0.0-ac29af4",
  "@metamask-previews/eth-snap-keyring": "7.0.0-ac29af4",
  "@metamask-previews/keyring-snap-client": "1.0.0-ac29af4",
  "@metamask-previews/keyring-snap-sdk": "1.0.0-ac29af4",
  "@metamask-previews/keyring-utils": "1.0.0-ac29af4"
}

@ccharly ccharly changed the title feat!: add scopes field to KeyringAccount feat!: add scopes field to KeyringAccount Dec 13, 2024
@ccharly ccharly changed the title feat!: add scopes field to KeyringAccount feat(keyring-api)!: add scopes field to KeyringAccount Dec 13, 2024
export enum BtcScopes {
Namespace = 'bip122',
Mainnet = 'bip122:000000000019d6689c085ae165831e93',
Testnet = 'bip122:000000000933ea01ad0ee984209779ba',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Testnet = 'bip122:000000000933ea01ad0ee984209779ba',
Testnet = 'bip122:000000000933ea01ad0ee984209779ba',
Testnet4 = 'bip122:00000000da84f2bafbbc53dee25a72ae',
Signet = 'bip122:00000008819873e925422c1ff0f99f7c',
Regtest = 'bip122:regtest',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants