Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License change 2.28 #8464

Merged

Conversation

daverodgman
Copy link
Contributor

@daverodgman daverodgman commented Nov 2, 2023

Description

Update to dual license

This also updates the header in library/mps_* (to remove 'this file is part of Mbed TLS'), and standardises the copyright in depends.py.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

@daverodgman daverodgman changed the base branch from development to mbedtls-2.28 November 2, 2023 19:09
@daverodgman daverodgman mentioned this pull request Nov 2, 2023
3 tasks
@daverodgman daverodgman added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests component-docs Docs / website issues filed here for tracking needs-reviewer This PR needs someone to pick it up for review priority-very-high Highest priority - prioritise this over other review work size-xs Estimated task size: extra small (a few hours at most) needs-work and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Nov 2, 2023
Signed-off-by: Dave Rodgman <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
@daverodgman daverodgman added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-work labels Nov 3, 2023
Signed-off-by: Dave Rodgman <[email protected]>
CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Dave Rodgman <[email protected]>
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My review metholodogy:

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Nov 3, 2023
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Nov 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 3, 2023
@daverodgman daverodgman added this pull request to the merge queue Nov 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 4, 2023
@gilles-peskine-arm gilles-peskine-arm removed the needs-ci Needs to pass CI tests label Nov 4, 2023
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Nov 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 4, 2023
@gilles-peskine-arm
Copy link
Contributor

This pull request has passed the PR tests on the merge queue but the merge queue failed due to a misconfiguration. I'm going ahead and merging immediately.

@gilles-peskine-arm gilles-peskine-arm merged commit 588feb8 into Mbed-TLS:mbedtls-2.28 Nov 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports component-docs Docs / website issues filed here for tracking priority-very-high Highest priority - prioritise this over other review work size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants