Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for propshaft #113

Closed
wants to merge 1 commit into from
Closed

Conversation

jvillarejo
Copy link
Contributor

@jvillarejo jvillarejo commented May 8, 2024

I am migrating my webapp to use propshaft and dartsass and removing sprockets as the asset pipeline.

This PR introduce a new AssetPropshadtProvider to resolve the assets instead of the AssetPipelineProvider.

Sadly I couldn't make the specs work without running rails assets:precompile in the dummy rails app.

But it works perfectly using it as a gem. Currently my webapp is pointing to my github repo fork.

It fixes #112

Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the only change I need

end
end
end
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new line at the end of file to prevent unnecessary code diffs in the future
Same for other files thx :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it ! Will do it.

@jvillarejo
Copy link
Contributor Author

Probably the only change I need

Done! Let me know if there is anything left I missed!

@jvillarejo
Copy link
Contributor Author

jvillarejo commented May 9, 2024

I'm closing this PR. I'm fixing a couple of issues I found. Sorry for this! I will reopen it again later when I fix them.

@jvillarejo jvillarejo closed this May 9, 2024
@jvillarejo
Copy link
Contributor Author

jvillarejo commented May 9, 2024

I reimplemented the solution and made another PR here: #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Has anyone tested Roadie with propshaft?
2 participants