Fix inheritance #79
Draft
Fix inheritance #79
+14
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Deewarz
commented
Feb 1, 2024
Deewarz
commented
- C_Car -> C_ActorVehicle -> C_Actor -> C_EntityPos -> C_Entity
- C_CrashObj -> C_ActorDeform -> C_Actor -> C_EntityPos -> C_Entity
|
This should be discuted more thoroughly because it has side effects on actual and upcoming sdk reversing |
- C_Car -> C_ActorVehicle -> C_Actor -> C_EntityPos -> C_Entity - C_CrashObj -> C_ActorDeform -> C_Actor -> C_EntityPos -> C_Entity
Deewarz
force-pushed
the
fix-car-crash-obj-inheritance
branch
from
3cfce10 to
33b002f
Compare
|
I keep this PR open as it requires more investigation / double checking to ensure w're not doing mistakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.