Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alias for training models #14

Open
allenday opened this issue Feb 16, 2021 · 3 comments
Open

add alias for training models #14

allenday opened this issue Feb 16, 2021 · 3 comments
Assignees

Comments

@allenday
Copy link

I see that this repo uses the pre-generated models from the sr repo:

https://github.com/MIR-MU/ffmpeg-tensorflow/blob/master/script/produce-sr-models#L18

Similarly to how you're aliasing the ffmpeg command to transcode
https://github.com/MIR-MU/ffmpeg-tensorflow/edit/master/README.md#L59

It would be great to also add an alias for training custom models, probably requiring some munging of:
https://github.com/HighVoltageRocknRoll/sr/blob/master/generate_datasets.sh
and
https://github.com/HighVoltageRocknRoll/sr/blob/master/train_srcnn.sh

@allenday
Copy link
Author

if you can do this I'll generate a model and send PR to this repo if you like @Witiko

@Witiko
Copy link
Member

Witiko commented Feb 18, 2021

@allenday That's a great idea. We are currently not shipping with Python, only FFMpeg with the Libtensorflow C library. Including Python would make the Docker image considerably larger and most users may not find it useful, so perhaps we could fork HighVoltageRocknRoll/sr and make a separate Docker image for training SRCNN, ESPCN, VSRNet, and VESPCN instead?

@allenday
Copy link
Author

sure that works - have two distinct dockerfiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants