Fix type for return_year in extreme.return_year_value #225
Conversation
|
Sorry about this, my mistake in the initial PR. I found it when trying to integrate v0.6.0 into a project. Is there a 'hot-fix' procedure that would mean a v0.6.1 would be possible with just this change (or any others that fix bugs)? |
|
Looks like there are quite a few test failures but they don't appear to be related to this code change. |
|
No worries @mbruggs we can tag a new release with this change. Thank you for posting this new PR. I am looking into the other failures. At first glance, It looks like matplotlib updated. |
|
Thanks @ssolson! |
|
#226 should fix the issues with the matplotlib update |
|
@mbruggs it is showing that you are trying to change 190 files currently. Can you resubmit this PR using the latest version of |
In an oversight in merging MHKiT-Software#193 the docstring was updated for the type of return_year in return_year_value but the corresponding assertion was not. Tests for the types of the two input parameters have been added to try to avoid a simular situation occuring the future.
mbruggs
force-pushed
the
fix/return-year-type
branch
from
efd5de4 to
8f4e0b9
Compare
|
Thanks for fixing the matplotlib issue so quickly, @ssolson. It seems to have fixed the tests Branch has been rebased so now only showing the files that have actually been changed. |
…#225) In an oversight in merging MHKiT-Software#193 the docstring was updated for the type of return_year in return_year_value but the corresponding assertion was not. Tests for the types of the two input parameters have been added to try to avoid a simular situation occuring the future.
**MHKiT 0.7.0 Release Notes** This release introduces exciting new features and improvements to the MHKiT package: - **Mooring Module**: We are pleased to introduce the new mooring module. This addition primarily supports outputs from MoorDyn. Within this module, users can: - Import data - Calculate lay length - Visualize mooring line movements in 2D and 3D with graphical animations. Accompanying this module is an example notebook to guide users on its functionalities. - **Dolfyn Module Revamp**: The Dolfyn module has been overhauled. Enhancements include: - Turbulence calculation capability - Performance measures for tidal power as outlined in IEC/TS 6200-200. - **New Contributions**: A big shoutout to our community member, @mbruggs, for adding the ability to compute surface elevation using IFFT. - **NDBC Buoy Metadata**: Users can now fetch NDBC buoy metadata directly through MHKiT. - **Delft3D Module Update**: Stay up to date with support for the latest Delft3D NetCDF format. **Additions** - #235 - #232 - #236 - #250 - #239 - #248 **Bug Fixes** - #226 - #238 **Meta/Minor Changes** - #220 - #243 - #225 - #231 - #224 Thank you to all of the contributers who helpped with this release: @mbruggs @Graham-EGI @castillocesar @jmcvey3 @hivanov-nrel @browniea @cmichelenstrofer @akeeste @maxwelllevin @rpauly18 @ssolson
In an oversight in merging #193 the docstring was updated for the type of return_year in return_year_value but the corresponding assertion was not.
Tests for the types of the two input parameters have been added to try to avoid a simular situation occuring the future.