Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dyson Pure Cool TP4B Fan #807

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Conversation

r-cz
Copy link
Contributor

@r-cz r-cz commented Oct 4, 2024

New file addition:

  • Fans/Dyson/Dyson_Pure_Cool_TP4B.ir: Added a new file with IR signal data for the Dyson Pure Cool TP4B Fan, matching the button names and ordering of the existing TP4A fan .ir file.

File renaming and updates:

  • Fans/Dyson/Dyson_Pure_Cool_TP4A.ir: Renamed from Fans/Dyson/Dyson_TP4A.ir and updated the name comment to "Dyson Pure Cool TP4A Fan" to be more specific per contribution guidelines.

@jaylikesbunda
Copy link
Contributor

these look like they contain duplicate signals do they work for each other?

New file addition:

* [`Fans/Dyson/Dyson_Pure_Cool_TP4B.ir`](https://github.com/Lucaslhm/Flipper-IRDB/pull/807/files#diff-2f70a2b55225ceb651ec3aa814b01cf5d23237ce671c885cd5d763b44f5fb881R1-R52): Added a new file with IR signal data for the Dyson Pure Cool TP4B Fan, matching the button names and ordering of the existing TP4A fan `.ir` file.

File renaming and updates:

* [`Fans/Dyson/Dyson_Pure_Cool_TP4A.ir`](https://github.com/Lucaslhm/Flipper-IRDB/pull/807/files#diff-22387af9ddbe031a0a666466e57371f4714f32f4133fc9b31bcc7275a0f72a68L4-R4): Renamed from `Fans/Dyson/Dyson_TP4A.ir` and updated the name comment to "Dyson Pure Cool TP4A Fan" to be more specific per contribution guidelines.

@r-cz
Copy link
Contributor Author

r-cz commented Oct 8, 2024

Hmm, good point — I wish I had a TP4A to test but I do not, and I’m not familiar enough with IR to say for sure if they are close enough to work with each other but they do look very similar. In fact, it looks like the existing TP4A data has some long pauses (e.g. 49564 - I assume due to long button presses), and the data prior to those pauses does look much more similar to the TP4B data. To be sure, I did at least recapture the TP4B signals with cleaner data (just 45 samples per button - I also probably held the buttons too long previously).

Anyway, I just reached out to Dyson chat and they said they would not work interchangeably, but I’m not really sure I trust that.

@darmiel
Copy link
Collaborator

darmiel commented Oct 26, 2024

I think in this case its fine to have both. If someone can test with both and confirm that the TP4A remote works with the TP4B, we can add that in a comment later

@darmiel darmiel merged commit 7bcc319 into Lucaslhm:main Oct 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants