Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macOS): Traffic light isn’t vertical in first time open #137

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Dec 1, 2024

Summary by Sourcery

Bug Fixes:

  • Fix the issue where the traffic light buttons on macOS were not vertical when the application was opened for the first time.

Copy link

sourcery-ai bot commented Dec 1, 2024

Reviewer's Guide by Sourcery

This PR fixes a macOS-specific issue by relocating the traffic light (window control buttons) positioning code. The code to set the vertical alignment of the window control buttons has been moved to execute after the window is shown, with a note to eventually move it to the NSWindowController.windowWillLoad method after a future bitdojo_window rewrite.

Sequence diagram for macOS window control button alignment

sequenceDiagram
    participant Main as Main Function
    participant AppWindow as App Window
    participant MacOSManager as MacOSWindowControlButtonManager

    Main->>AppWindow: Initialize app window
    AppWindow->>AppWindow: Show window
    Note right of AppWindow: Window is now visible
    AppWindow->>MacOSManager: Set vertical alignment of control buttons
    Note right of MacOSManager: Alignment set after window is shown
Loading

File-Level Changes

Change Details Files
Relocated the window control buttons (traffic light) vertical alignment code
  • Removed the vertical alignment setup from the initialization phase
  • Added the vertical alignment setup after the window is shown
  • Added a TODO comment indicating future plans to move the code to NSWindowController.windowWillLoad
lib/main.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 6ef9e41 into Losses:master Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants