hide unexpected_cfgs warnings in proc-macro generated code
#287
+44
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new impls should be identical, but they have the advantage that we can move them around. See the next patch for why this is useful.
AFAICT it's not possible to set `#[allow(unexpected_cfgs)]` on a `#[cfg(...)]` or `#[cfg_attr(...)]` directly. Instead, we have to crate a new scope and use `#[allow(...)]` on that. This patch wraps all uses of `target_arch = "spirv"` in an unnamed constant scope and uses `#[allow(unexpected_cfgs)]` on it.
fu5ha
approved these changes
Nov 30, 2024
Lokathor
added
semver-patch
|
released in bytemuck_derive-1.8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286