This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Breaking: parent db must support deferredOpen #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent database must support deferredOpen
By parent we mean:
By deferredOpen we mean that the db opens itself and defers operations until it's open. Currently that's only supported by
levelup
(andlevelup
factories likelevel
). Previously,subleveldown
would also acceptabstract-leveldown
db's that were not wrapped inlevelup
.Better isolation
Opening and closing a sublevel no longer opens or closes the parent db. The sublevel does wait for the parent to open (which in the case of
levelup
already happens automatically) but never initiatesa state change on the parent.
If one closes the parent but not the sublevel, subsequent operations on the sublevel (like
get
andput
) will yield an error, to prevent segmentation faults from underlying stores.Drops support of old modules
memdb
(uselevel-mem
instead)deferred-leveldown
< 2.0.0 (and thuslevelup
< 2.0.0)abstract-leveldown
< 2.4.0Rejects new sublevels on a closing or closed database
Closes #84, closes #83, closes #60 and paves the way for Level/community#83.