This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
Update abstract-leveldown to the latest version 🚀 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
greenkeeper
bot
added
the
dependencies
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vweevers
force-pushed
the
greenkeeper/abstract-leveldown-6.0.0
branch
from
0abfde8 to
4718274
Compare
|
Luckily I could cherry pick almost everything from |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Handle location in constructor at it was removed from abstract-leveldown * Pass a factory function to abstract tests * Use tempy in tests, removing need for cleanup * Use level-concat-iterator in tests
* Invoke abstract tests from single function * Options is actually now passed as options from abstract-leveldown and not a function
With undefined behavior for nullish targets (range options and seek targets). Previously, nullish range options were ignored and seek(null) and seek(undefined) would throw an error. Now they translate to String(null) and String(undefined). This change makes it explicit that rocksdb only supports buffers and strings. Nullish targets do have a meaning in the ecosystem; that meaning should be given at a higher level like encoding-down. In other words, it isn't rocksdb's concern anymore.
* Restore (but skip) segfault test from abstract-leveldown * Prevent segfault when calling iterator() on non-open db
* make callback of makeTest an error-first callback * normalize error assertions in tests that use makeTest
* handle errors in compactRange test * use batch() in compactRange test * serialize compactRange() start and end * copy type checks from approximateSize to compactRange
vweevers
force-pushed
the
greenkeeper/abstract-leveldown-6.0.0
branch
from
4718274 to
dd18a98
Compare
|
@vweevers I've reviewed batch.h, batch.cc, batch_async.h, batch_async.cc, and related parts in database.cc. LGTM! |
peakji
approved these changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency abstract-leveldown was updated from
5.0.0to6.0.0.This version is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
Release Notes for v6.0.0
If you are upgrading, please consult the Upgrade Guide.
Changed
airtapdevDependency from0.0.5to0.1.0(#229, #231, #245,029f56a, #252) (@vweevers, @ralphtheninja)sinondevDependency from^5.0.0to^6.0.0(#232) (@ralphtheninja)standarddevDependency from^11.0.0to^12.0.0(#303) (@ralphtheninja)_serializeKeyand_serializeValueidentity functions (#277) (@vweevers)dbproperty mandatory and public on iterator and chained batch (#257, #309) (@vweevers)AbstractChainedBatch#_clearwith_putand_del(#257) (@vweevers)AbstractChainedBatch#_writewith options (#257) (@vweevers)level-concat-iteratorinstead ofcollectEntries(#246) (@ralphtheninja)dbinstances in test suite (#258, #268, #282) (@ralphtheninja, @vweevers)abstract/totest/(#253) (@vweevers)(test, testCommon)(#268, #275) (@ralphtheninja)exports.*overmodule.exports.*(#276) (@ralphtheninja)0b2949a) (@ralphtheninja)Added
iterator#seek()(#237, #302, #307) (@vweevers, @ralphtheninja)nycandcoverallsdevDependencies for code coverage (#253) (@vweevers)setUpandtearDownto all sub tests (#279, #289) (@ralphtheninja)hallmarkdevDependency for Markdown style and contributors (#312) (@vweevers)Removed
location(#258) (@ralphtheninja)lastLocation,cleanup,rimraf(#249) (@vweevers)0b52395) (@ralphtheninja)nullmeant "not defined" (#277) (@vweevers)test/put-test.js(#300) (@ralphtheninja)errorValues()test (#273) (@ralphtheninja)testCommonparameter (#264, #271) (@vweevers)contributorsfrompackage.json(542f350) (@ralphtheninja)a36c04f) (@ralphtheninja)Fixed
t.throwtests check error messages correctly (#286) (@ralphtheninja)null(#257, #288) (@ralphtheninja, @vweevers)Commits
The new version differs by 54 commits.
af123486.0.017328cePrepare 6.0.0 (#312)5b4c550Make db property mandatory and public on iterator and chained batch (#309)b610da0Import seek tests from leveldown (#307)e7285bbreadme: undefined behavior for nullish range options is legit (#305)0f42686Merge pull request #303 from Level/greenkeeper/standard-12.0.01170ceachore(package): update standard to version 12.0.0a6c733bFix bug in AbstractIterator#_seek (#302)aeabe99Remove sync test (#300)51af868Add 'bufferKeys' and 'seek' to skip options (#297)76f0477add Spread The Word and Install sections (#296)6311faeadd test suite documentation (#295)adac630Update upgrade guide [wip] (#272)e8415d5Update changelog for v6 (#291)a8aa1c2Merge testCommon and test options (#293)There are 54 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴