Add db.getMany(keys) #184
Add db.getMany(keys) #184
Conversation
|
One PR is fine with me; just keep the individual commits. |
MeirionHughes
changed the title
|
Did you have any conflicts when cherry-picking? |
Good catch. |
There was a problem hiding this comment.
I'll want to merge this with a "Rebase and merge", meaning all commits of this PR will go into master. Can you replace the broken leveldown references in the commit messages with links to either leveldown commits or PRs? Taking 84a05e8 as an example, change its message from:
Close database on environment exit (#783)
Closes #667, closes #755.
To:
Close database on environment exit
Ported from https://github.com/Level/leveldown/pull/783
Some examples from rocksdb history: 891bb7a, 69e3dcb, 5eee577. The format doesn't matter much, just that we'll know where these rocksdb commits came from.
MeirionHughes
force-pushed
the
cherry-leveldown-783
branch
from
968cfcb to
5eb9212
Compare
|
I picked them into a seperate branch and amended each with their original sha's from levelup, then forced that branch back to this PR. That okay? on the PR they're showing up but github isn't making them a link for me. I guess it needs an actual http link... ? sigh lol. I'll do it again |
|
They're cross-repo references, so for them to be auto-linked by GitHub, commits require the format |
(cherry picked from commit Level/leveldown@8fdcaaa)
(cherry picked from commit Level/leveldown@d3453fb)
Because this uses an iterator under the hood, it also refactors shared code between `db.iterator()` and `db.clear()`. (cherry picked from commit Level/leveldown@aedf49e)
(cherry picked from commit Level/leveldown@9a3f59a)
(cherry picked from commit Level/leveldown@0f88586)
(cherry picked from commit Level/leveldown@7356ba4)
By using `emplace_back()`, reusing the `std::vector` cache between `iterator.next()` calls, and not advancing the iterator prematurely. That last one only matters for single reads (i.e. the first `next()` call or one made after seeking) and it doesn't improve performance compared to the previous release, just undoes a mistake in Level/leveldown@b815bea. (cherry picked from commit Level/leveldown@112906b)
And add `const` and `private` where appropriate. (cherry picked from commit Level/leveldown@576d135)
(cherry picked from commit Level/leveldown@50dc50b)
|
You might like git's interactive rebase, allows you to edit commit messages (and more) on the same branch. |
MeirionHughes
force-pushed
the
cherry-leveldown-783
branch
from
5eb9212 to
17d4116
Compare
hu... I didn't know you could do that. It shows up on tortoise git if I try to rebase the branch to an earlier point and select Force Rebase. Well they should all have links now. hopefully... |
#183
@vweevers I've never actually cherry picked (in like 15 years) - this seemed to have no issues being picked and applied. So you want them all in one, or one PR at a time?