Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

chore: update deps #373

Merged
merged 2 commits into from
Apr 3, 2021
Merged

chore: update deps #373

merged 2 commits into from
Apr 3, 2021

Conversation

achingbrain
Copy link
Contributor

Updates Buffer to the latest version as having multiple versions in
the dep tree causes quite a lot of bundle bloat when run in browsers!

Updates `Buffer` to the latest version as having multiple versions in
the dep tree causes quite a lot of bundle bloat when run in browsers!
@vweevers vweevers added the semver-major Changes that break backward compatibility label Mar 31, 2021
@vweevers
Copy link
Member

vweevers commented Mar 31, 2021

Semver-major because it drops support of IE11 and Safari 9-10 (feross/buffer@840160f). @achingbrain Could you remove IE11 from .airtap.yml?

@achingbrain
Copy link
Contributor Author

Done!

achingbrain added a commit to achingbrain/level-js that referenced this pull request Mar 31, 2021
Updates `Buffer` to the latest version as having multiple versions in
the dep tree causes quite a lot of bundle bloat when run in browsers!

Refs: Level/abstract-leveldown#373
achingbrain added a commit to achingbrain/codec that referenced this pull request Mar 31, 2021
Updates `Buffer` to the latest version as having multiple versions in
the dep tree causes quite a lot of bundle bloat when run in browsers!

Refs: Level/abstract-leveldown#373
@vweevers
Copy link
Member

vweevers commented Apr 3, 2021

Ran browser tests on a temporarily expanded matrix, all good! Safari 11 on Mac failed, but seeing as iOS Safari 11 did succeed, I think it was a random or at least unrelated failure. Will retry that.

image

@vweevers
Copy link
Member

vweevers commented Apr 3, 2021

Was indeed unrelated. Safari threw TypeError: Value is not a sequence upon console.log(..), which is caused by the WebDriver extension that Sauce Labs has installed on MacOS 10.12, but luckily not on 10.13 so I switched to that. Tests passed.

image

@vweevers vweevers merged commit f62f38b into Level:master Apr 3, 2021
vweevers pushed a commit to Level/codec that referenced this pull request Apr 4, 2021
@vweevers
Copy link
Member

vweevers commented Apr 9, 2021

I've since removed the need for buffer: 8f79234

@vweevers
Copy link
Member

vweevers commented Apr 9, 2021

7.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semver-major Changes that break backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants