Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Fix panic when placing ghost #765

Merged
merged 5 commits into from
Apr 25, 2023
Merged

Fix panic when placing ghost #765

merged 5 commits into from
Apr 25, 2023

Conversation

alice-i-cecile
Copy link
Contributor

Decided to tackle this more robustly / defensively by implementing try_insert as a method on EntityCommands.

Panics due to failure to find the entity are dumb in this case, so let's not.

@alice-i-cecile alice-i-cecile enabled auto-merge (squash) April 25, 2023 22:47
@alice-i-cecile alice-i-cecile added bug Something isn't working critical Blocking further work from being done labels Apr 25, 2023
@alice-i-cecile alice-i-cecile merged commit 0bd6895 into main Apr 25, 2023
@alice-i-cecile alice-i-cecile deleted the ambiguities-yeet branch April 25, 2023 23:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working critical Blocking further work from being done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant