Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wb_cirrus_search #265

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add wb_cirrus_search #265

wants to merge 1 commit into from

Conversation

LeMyst
Copy link
Owner

@LeMyst LeMyst commented Dec 18, 2021

@LeMyst LeMyst changed the title Update wbi_helpers.py Add wb_cirrus_search Dec 18, 2021
@LeMyst LeMyst linked an issue Dec 18, 2021 that may be closed by this pull request
@dpriskorn
Copy link
Contributor

This should fix the bug that the build system complains about:

search_string = (
                f"{search_string} "
                f"haswbstatement:{statement.mainsnak.property_number}="
                f"{statement.mainsnak.datavalue}"
            )

@dpriskorn
Copy link
Contributor

Here is my suggestion for warning the user

    if max_results > 10000:
        log.warning("Wikidata has a hardcoded limit of 10.000 results "
                    "maximum. Setting max_results=10000")
        max_results = 10000

@LeMyst LeMyst added the enhancement New feature or request label Jan 23, 2022
@LeMyst LeMyst changed the base branch from rewrite-wbi to master July 14, 2022 17:44
@LeMyst LeMyst force-pushed the add-cirrus-search branch from 81ce197 to 148b73a Compare January 8, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support query in a helper function
2 participants