Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding around header title text #356

Merged
merged 2 commits into from
Jan 9, 2016
Merged

Fix padding around header title text #356

merged 2 commits into from
Jan 9, 2016

Conversation

florabtw
Copy link
Contributor

@florabtw florabtw commented Jan 9, 2016

Covers secondary issues brought up in #305, along with some code cleanup.

Header Title (before)

navbar-old

Header Title (after)

navbar-new

Settings Title (before)

settings-old

Settings Title (after)

settings-new

Nick Pierson added 2 commits January 8, 2016 15:03
- Padding is made more consistent around the hamburger menu (15px instead of 20)
- Padding is added to the right of the header title text so that it doesn't
  look crowded when hovering

the class structure was moderately refactored in order to remove
`navbar-brand` from the header title link, as it seemed to be doing more
harm than good.
Also removes `navbar-brand` from settings header title to stay consistent with
the notes header title.
wwwredfish added a commit that referenced this pull request Jan 9, 2016
Fix padding around header title text
@wwwredfish wwwredfish merged commit 886cd1d into Laverna:dev Jan 9, 2016
@wwwredfish
Copy link
Member

Thanks for PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants