Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs and usability issues identified in LABS-362 #205

Open
wants to merge 9 commits into
base: release/10.0
Choose a base branch
from

Conversation

lasley
Copy link
Member

@lasley lasley commented May 11, 2017

Squashed commits:
[94b0b23] [IMP] medical_medicament_us: Improve nested NDC form

  • Create custom nested NDC form with active toggle and split groups
    [a8b8b33] [IMP] medical: Move active toggle to abstract entity

  • Move active toggle button to abstract entity button box to reduce code dup
    [6e50f1d] [IMP] medical_medicament_us: Add active flag

  • Add an active flag for NDCs to allow for more granular reporting
    [1ec637c] [FIX] medical_center: Move centers in patient view

  • Move medical centers to right group in patient view, instead of title area
    [b3657e5] [IMP] medical: Patient view xpaths

  • Switch patient view xpaths to use pre-defined entity groups to provide commonality
    [43451d3] [FIX] website_sale_medical_prescription: Fix gender attribute
    [4117591] [FIX] website_medical_patient: Fix gender attribute
    [038ec40] [FIX] sale_medical_prescription: Fix attributes

  • Fix patients assigned as partners

  • Fix usage of dosage quantity as order line
    [7a3793f] [IMP] sale_stock_medical_prescription_us: Switch to product_uom

  • Switch reference to use product_uom days instead of now nonexistent medicament
    [1ce4261] [IMP] medical_medication: Remove uom data

  • Remove UOM data in favor of product_uom, which contains the same thing now
    [9be7200] [IMP] sale_stock_medical_prescription: Change rx force context key

  • Change context key to force prescription dispenses from __rx_force__ to rx_no_validate to match partner Id validate skip introduced in [IMP] partner_identification: Add context override OCA/partner-contact#373
    [3742154] [IMP] medical_patient_us: Activate module
    [b7e00e7] [FIX] medical_medicament_us: Fix GCN display ([FIX] medical_medicament_us: Fix GCN display #127)

  • [FIX] medical_medicament_us: Fix GCN display

  • Add name_get to display GCN with prepended zero pads.

  • [IMP] medical_medicament_us: Change GCN to int

  • Updates per PR

  • [FIX] website_sale_medical_medicament_us: Fix GCN

  • Update GCN to appropriate code

@lasley lasley added this to the 10.0 milestone May 11, 2017
@lasley lasley self-assigned this May 11, 2017
@lasley lasley requested a review from tedsalmon May 11, 2017 19:45
@lasley lasley force-pushed the hotfix/10.0/LABS-362-carepoint_connector branch 7 times, most recently from 4358ad4 to 2eff15a Compare May 12, 2017 01:25
@codecov-io
Copy link

codecov-io commented May 12, 2017

Codecov Report

Merging #205 into release/10.0 will decrease coverage by 5.14%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##           release/10.0     #205      +/-   ##
================================================
- Coverage          88.1%   82.95%   -5.15%     
================================================
  Files               124      118       -6     
  Lines              2328     2124     -204     
================================================
- Hits               2051     1762     -289     
- Misses              277      362      +85
Impacted Files Coverage Δ
...ock_medical_prescription/models/sale_order_line.py 88.7% <100%> (-9.3%) ⬇️
...ption_us/models/medical_prescription_order_line.py 100% <100%> (+2.81%) ⬆️
medical_patient_us/models/medical_patient.py 100% <100%> (ø)
...cal_medicament_us/models/medical_medicament_ndc.py 100% <100%> (ø) ⬆️
website_portal_medical_patient/controllers/main.py 28.57% <0%> (-68.1%) ⬇️
...edical_prescription_order_line/controllers/main.py 43.75% <0%> (-56.25%) ⬇️
website_portal_medical/controllers/main.py 23.8% <0%> (-50.01%) ⬇️
...portal_medical_patient_species/controllers/main.py 50% <0%> (-50%) ⬇️
...tock_medical_prescription_us/models/res_company.py 83.33% <0%> (-16.67%) ⬇️
...site_pricelist_medical_insurance/models/website.py 52.38% <0%> (-14.29%) ⬇️
... and 37 more

@lasley lasley force-pushed the hotfix/10.0/LABS-362-carepoint_connector branch 2 times, most recently from eadd498 to 1b47c9f Compare June 21, 2017 19:51
@lasley lasley force-pushed the hotfix/10.0/LABS-362-carepoint_connector branch 3 times, most recently from e5b7369 to b27fb30 Compare July 10, 2017 01:12
@lasley lasley removed the request for review from tedsalmon July 28, 2017 01:50
@lasley lasley force-pushed the hotfix/10.0/LABS-362-carepoint_connector branch 2 times, most recently from 9134d91 to c52b8bb Compare July 29, 2017 00:22
@lasley lasley force-pushed the hotfix/10.0/LABS-362-carepoint_connector branch 2 times, most recently from 9e5bd5c to 4444387 Compare August 8, 2017 22:25
@lasley lasley force-pushed the hotfix/10.0/LABS-362-carepoint_connector branch from 7665061 to b93103f Compare August 31, 2017 01:21
Ted Salmon and others added 7 commits September 6, 2017 15:18
Squashed commits:
[345fdd3] Allow Rx substitution using GCN if not same product
[bcfe1bd] Remove required from pathology in disease
[ee23f93] Fix day reference
[1b47c9f] Fix bugs and usability issues identified in LABS-362
Squashed commits:
[94b0b23] [IMP] medical_medicament_us: Improve nested NDC form
* Create custom nested NDC form with active toggle and split groups
[a8b8b33] [IMP] medical: Move active toggle to abstract entity
* Move active toggle button to abstract entity button box to reduce code dup
[6e50f1d] [IMP] medical_medicament_us: Add active flag
* Add an active flag for NDCs to allow for more granular reporting
[1ec637c] [FIX] medical_center: Move centers in patient view
* Move medical centers to right group in patient view, instead of title area
[b3657e5] [IMP] medical: Patient view xpaths
* Switch patient view xpaths to use pre-defined entity groups to provide commonality
[43451d3] [FIX] website_sale_medical_prescription: Fix gender attribute
[4117591] [FIX] website_medical_patient: Fix gender attribute
[038ec40] [FIX] sale_medical_prescription: Fix attributes
* Fix patients assigned as partners
* Fix usage of dosage quantity as order line
[7a3793f] [IMP] sale_stock_medical_prescription_us: Switch to product_uom
* Switch reference to use product_uom days instead of now nonexistent medicament
[1ce4261] [IMP] medical_medication: Remove uom data
* Remove UOM data in favor of product_uom, which contains the same thing now
[9be7200] [IMP] sale_stock_medical_prescription: Change rx force context key
* Change context key to force prescription dispenses from `__rx_force__` to `rx_no_validate` to match partner Id validate skip introduced in OCA/partner-contact#373
[3742154] [IMP] medical_patient_us: Activate module
[b7e00e7] [FIX] medical_medicament_us: Fix GCN display (#127)

* [FIX] medical_medicament_us: Fix GCN display
* Add `name_get` to display GCN with prepended zero pads.

* [IMP] medical_medicament_us: Change GCN to int
* Updates per PR

* [FIX] website_sale_medical_medicament_us: Fix GCN
* Update GCN to appropriate code
@lasley lasley force-pushed the hotfix/10.0/LABS-362-carepoint_connector branch from b93103f to a4e985d Compare September 6, 2017 22:36
* Add copyright headers on files that have not been entirely rewritten
* Add modified work statements on modules that evolved from GNUHealth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants