Core rewrite #21
Core rewrite #21
Conversation
KubEF
force-pushed
the
core-rewrite
branch
2 times, most recently
from
0543f05 to
4f1e47f
Compare
Data types and representation of edges. Also functions to apply reduction and supporting functions.
Fix new version fourmolu warnings
Also write helper module with generators of Address, Port and Node. Hope to use that in more complex tests
There was a problem hiding this comment.
This is a first look at this code. It's very complicated both syntactically and semantically. I couldn't wrap my head about semantics of this code today, just updateMM requires ton of courage to approach. Thus, here mostly syntactical comments, but I'll definitely give this code another try in some time.
Simplified update function Add simpliest doctest
Add type alias for Ram Move most of helping function to top-level Replace ^. to view
Add epsilon agent Move concrete reduction rules into separate functions add docs with images to them
| ReduceRuleResult 0 2 2 | ||
| lNode |><| rNode = case (lNode ^. nodeType, rNode ^. nodeType) of | ||
| (Apply, Abs) -> applyToLambdaRule lNode rNode | ||
| (Abs, Apply) -> applyToLambdaRule lNode rNode |
There was a problem hiding this comment.
Should it be applyToLambdaRule rNode lNode?
lamagraph-core/src/INet/Net.hs
Outdated
| data AgentSimpleLambda | ||
| = Apply | ||
| | Abs | ||
| | Eps |
There was a problem hiding this comment.
erase in Lafont
delete agent in Interaction nets in Ocaml
lamagraph-core/src/INet/Net.hs
Outdated
|
|
||
| data AgentSimpleLambda | ||
| = Apply | ||
| | Abs |
| ActivePair portsNumber -> | ||
| ReduceRuleResult nodesNumber edgesNumber portsNumber -> | ||
| Delta nodesNumber edgesNumber portsNumber | ||
| toDelta acPair reduceResult = Delta (reduceResult ^. nodes) (reduceResult ^. edges) acPair |
There was a problem hiding this comment.
acPair -> activePair
reduceResult -> reductionResult
There was a problem hiding this comment.
activePair clash with _activePair in Delta. So, because of lenses it is function name. acPair is necessary compromise.
lamagraph-core/src/Core/Reducer.hs
Outdated
| (Node portsNumber -> Node portsNumber -> ReduceRuleResult nodesNumber edgesNumber portsNumber) -> | ||
| Signal dom (ActivePair portsNumber) -> | ||
| Signal dom (Delta nodesNumber edgesNumber portsNumber) | ||
| reducer transFunction activeP = toDelta <$> activeP <*> reduceRuleRes |
There was a problem hiding this comment.
activeP -> activePair
transFunction -> transitionFunction ? transformFunction
| deleteActivePair oldActivePairs activePairToDelete = | ||
| if leftInVec `xor` rightInVec | ||
| then newActivePairs | ||
| else error "In active pairs map should be exact one address" |
There was a problem hiding this comment.
I'm not sure that message is informative enough. Even more, I'm not sure that I realize what it means.
| <*> signalLoadedNode | ||
| <*> (view (containedNode . primaryPort) <$> signalLoadedNode) | ||
| <*> pure Primary | ||
| in ifoldl |
There was a problem hiding this comment.
Does associativity matter? Can fold be used?
Add plugins with solvers in setup part. Perhaps this can be solved more correctly
* Extract work with memory * Extract work with accumulated changes * Extract work with accumulating of changes * Add MemoryManager splitting in .cabal file
An approximate view of main function. !Do not handled the end point!
Add reduction rules and chooseReductionRule function
| (Eps, _) -> epsToAnyRule lNode rNode | ||
| (_, Eps) -> epsToAnyRule rNode lNode | ||
| (Apply, Abstract) -> applyToLambdaRule lNode rNode | ||
| (Abstract, Apply) -> applyToLambdaRule lNode rNode |
There was a problem hiding this comment.
Should be left and right node be switched?
| @@ -87,9 +87,12 @@ library | |||
| import: common-options | |||
| hs-source-dirs: src | |||
| exposed-modules: | |||
| Core.Core | |||
There was a problem hiding this comment.
Is Core' a good name for top-level ? May we use something like ReductionMachine` for top-level namespace?
| import Core.Reducer (ChooseReductionRule, getInterface, reducer) | ||
|
|
||
| core :: | ||
| forall portsNumber nodesNumber edgesNumber cellsNumber dom. |
There was a problem hiding this comment.
Can core be parametrized with single dom? What about different domains for memory, reducer, other parts?
| , HiddenClockResetEnable dom | ||
| , Enum AddressNumber | ||
| ) => | ||
| Vec cellsNumber (Maybe (Node portsNumber)) -> -- Initial network |
There was a problem hiding this comment.
Not a network, but active pairs. We need (at least) two layers: program loader and processor itself.
|
|
||
| 3. Written by hands for tests | ||
| -} | ||
| module Core.Concrete.ReduceRulesLambda where |
There was a problem hiding this comment.
My idea that in common case this module will generate automatically by Template Haskell and some dsl. It is just example for now, but something more complex in the future
| __Note__ this rule is not symmetric!! Erasure node is first | ||
| -} | ||
| eraseToAbstractOrApplyRule :: | ||
| Vec 2 (Maybe AddressNumber) -> |
There was a problem hiding this comment.
Why Maybe AddressNumber. All checks should be outside the logic.
There was a problem hiding this comment.
Without Maybe we need to change Vec size dynamically. It is impossible or very difficult. Or we should allocate a constant amount of memory, even if we don't need it. It is strange
| let f = Just (view originalAddress <$> signalLoadedNode, Just . view containedNode <$> signalLoadedNode) | ||
| in ram (pure 0) (traverse bundle f) | ||
|
|
||
| removeActivePairFromRam :: |
There was a problem hiding this comment.
Should it be here, not in Ram module?
| -- | Data to accumulate all `Port` changes of the `Node` | ||
| data Changes (portsNumber :: Nat) | ||
| = Changes | ||
| { _secP :: Vec portsNumber (Maybe (Connection portsNumber)) |
Some fixes and tonnes of rewriting from here.
I have some main questions in here