This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
Add Color3.new empty constructor and Color3.fromRGB #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I let this sit for so long! I was on vacation when it was submitted and then it fell off of my notifications. |
LPGhatguy
suggested changes
Jan 19, 2018
| it("should have an empty constructor", function() | ||
| local color = Color3.new() | ||
|
|
||
| assert.not_nil(color) |
There was a problem hiding this comment.
We should probably make sure that the result is {0, 0, 0} for the empty constructor
lib/types/Color3.lua
Outdated
| return { | ||
| r = r, | ||
| g = g, | ||
| b = b |
There was a problem hiding this comment.
Can you add a trailing comma here like the original block? It isn't that important here, but it makes diffs cleaner and makes it easier to change line ordering.
|
I can't do your changes right now, don't have access to a PC. I'd be happy to do it when I get the chance. |
|
@LPGhatguy Finished. |
|
I...have no idea why that check isn't successful? |
|
Weird, I don't understand why it would be failing either. |
LPGhatguy
approved these changes
Feb 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.