Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing expensive timers from SPHEvaluateDerivatives. #44

Merged
merged 2 commits into from
Jan 9, 2021
Merged

Removing expensive timers from SPHEvaluateDerivatives. #44

merged 2 commits into from
Jan 9, 2021

Conversation

mdavis36
Copy link
Collaborator

@mdavis36 mdavis36 commented Jan 8, 2021

Removes timer code from SPHEvaluateDerivatives and SolidSPHEvaluateDerivatives which were causing performance hits.

@mdavis36 mdavis36 requested a review from jmikeowen January 8, 2021 23:06
jmikeowen
jmikeowen approved these changes Jan 9, 2021
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some more instances of the same pattern as well, and tested it out on LC. Looks good.

@jmikeowen jmikeowen merged commit e652ba0 into develop Jan 9, 2021
@jmikeowen jmikeowen deleted the SPHEvalDerivTimers branch January 9, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdavis36 @jmikeowen