Named timing output file #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdavis36
commented
Jan 4, 2021
| TimerSummary(); // backwards compatibilty... | ||
| } | ||
|
|
||
| static void TimerSummary(void); |
There was a problem hiding this comment.
@jmikeowen I know passing void as an argument type is a C trick for explicitly defining a function takes 0 arguments. Does removing this break some interoperability with the C wrapping library that I may not be aware of?
There was a problem hiding this comment.
I don't think you're breaking anything there. This Timer class stuff is a really old version of something constructed by Noel Keen years ago, who now works at Lawrence Berkeley Lab still on performance stuff. You could ask him ([email protected]) for more info on why he did it this way, and he likely has some updated version of this by now.
jmikeowen
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to define a name for a given output timing file. If no name is passed to the SpheralController the default name
time.tablewill be used and behavior will remain the same.