Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting more unique output test paths for planar porosity compaction #251

Merged
merged 16 commits into from
Jan 16, 2024

Conversation

jmikeowen
Copy link
Collaborator

@jmikeowen jmikeowen commented Jan 2, 2024

This PR is to make our CI testing with one of the new porosity tests (planar compaction) more robust. It appears to have had some race conditions possible with removing directories when testing in parallel in the CI.

Summary

  • This PR is a bugfix
  • It does the following:
    • Alters the output paths for one test when run under the ATS
    • Updates tolerances for several tests which occasionally were failing
    • Updates the local copy of lcats to run on the current LC machine configurations

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

test to make more robust in automatic testing in parallel.
@mdavis36 mdavis36 added this to the 2024.01.0 Release milestone Jan 2, 2024
@jmikeowen jmikeowen requested a review from mdavis36 January 12, 2024 00:25
@jmikeowen jmikeowen merged commit ab6e037 into develop Jan 16, 2024
1 check passed
@jmikeowen jmikeowen deleted the bugfix/Palpha_testing branch January 16, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants