Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fsisphInterfaces #239

Merged
merged 26 commits into from
Dec 14, 2023
Merged

Feature/fsisphInterfaces #239

merged 26 commits into from
Dec 14, 2023

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Sep 22, 2023

Summary

  • NOTE : this PR breaks backwards compatibility for the FSISPH package. Constructor arguments have changed.

This PR updates the following in the FSISPH solver:

  • Interface fieldLists have been updated to be more robust and add functionality. A new fieldlist is introduced to FSISPH "interfaceAreaVector" which allows pressure boundaries to be applied to free surfaces. "interfaceFlags" are added to more robustly identify material interfaces and free surfaces.
  • To control tensile instability, XSPH is updated to only be applied in regions where negative pressure exist.
  • Decoupling logic is updated to account for recent changes in spheral's strength and damage models
  • The option to evolve the deviatoric stress in plane-strain mode is added for 2d/1d simulations
  • User can now specify an "interfacePmin" which sets the minimum pressure across material interfaces
  • pressure/rawPressure switched to damagedPressure/pressure, this fixes a bug related to what pressure is fed in to the calculation of strain for the damage model. The new names are more clear as well.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmpearl jmpearl changed the title Feature/fsisp hinterfaces Feature/fsisphInterfaces Sep 22, 2023
@mdavis36 mdavis36 added this to the 2024.01.0 Release milestone Dec 4, 2023
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jmpearl jmpearl merged commit 400f761 into develop Dec 14, 2023
1 check passed
@jmpearl jmpearl deleted the feature/FSISPHinterfaces branch December 14, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants