Flat connectivity updates and axom 0.7.0 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ALE3D is already on Axom 0.7.0 (commit 3d77e46). I can try building with these changes. |
jmikeowen
reviewed
Apr 13, 2023
|
Overall looking fine to me. I have one question about FlatConnectivity above, and we should get up to date with develop and confirm the CI is passing, but then I think this is ready to go. |
mdavis36
requested changes
Jun 8, 2023
mdavis36
requested changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds one function and lots of comments to the FlatConnectivity class.
This also includes the necessary changes for axom 0.7.0, which is what we are using in Blast.
ALE3D uses axom 0.5.0, so we may need to figure out how to handle a version difference there.Edit: ALE3D is also on Axom 0.7.0. #205 (comment)