Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/offline build #161

Merged
merged 20 commits into from
Sep 22, 2022
Merged

Bugfix/offline build #161

merged 20 commits into from
Sep 22, 2022

Conversation

mdavis36
Copy link
Collaborator

@mdavis36 mdavis36 commented Sep 15, 2022 •
edited
Loading

Summary

This PR helps to enable Spheral to build within an environment without internet connection provided TPLs are available.

  • All Python runtime libraries are managed by spack.
    • Removal of all python module related CMake files / code.
  • Dockerfile changes to enable testing a Spheral build in a two stage process.
    1. Build and install all TPLs through tpl-manager / spack to a docker container as normal.
    2. Build, install and test spheral with the pre-installed Python libraries in and environment without a network connection.
  • Azure Pipelines has been replaced with github actions to enable support for github container repository (ghcr.io) hosting of our latest develop Spheral build on x86 machines.

@mdavis36
First pass, trying to fix offline builds.
1d0482a
@mdavis36
spack runtime python library management.
dacd21f
@mdavis36
Cleanup; Delete old files
12dddd4
@mdavis36
Fixing py-pillow-simd issue on powerpc; Fix Docs w/ spack python runt…
17d715e 
…ime libs; Fix ATS python execution source when installing to a virtual environment.
@mdavis36
Removing old python cmake tpl files.
05cef59
@mdavis36
Cleanup pass...
eb63f9a
@mdavis36
UTF-8 codec fix for strange spack pip failure when local env not set.
8671501
@mdavis36
Merge branch 'develop' into bugfix/offline-build
3144f9e
@mdavis36
Fixing dependencies for external builds w/ spack python packages.
6f3a9d8
@mdavis36
Commenting dockerfile and fixing typos.
178fd81
@mdavis36
Try to run offline docker build and test on azure.
fd08d0c
@mdavis36
Uberenv w/ spack-url option.
44171a4
@mdavis36
--spack-url
4810348
@mdavis36
Adding docker-image workflow
357f3d3
@mdavis36
typo
1adcfcd
@mdavis36
Specify path for env build
a9b73e5
@mdavis36
recursive submodules
c5c5057
@mdavis36
lowercase image name
cbd9c6a
@mdavis36
Cleanup pass.
28b7547
@mdavis36
Offline-build fix notes.
fb76fe1
@mdavis36 mdavis36 changed the base branch from develop to bugfix/LLNLSpheral-lib-fix September 21, 2022 23:26
@mdavis36 mdavis36 marked this pull request as ready for review September 21, 2022 23:26
jmikeowen
jmikeowen approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work getting this going MIke.

@mdavis36 mdavis36 merged commit f42b98e into bugfix/LLNLSpheral-lib-fix Sep 22, 2022
@mdavis36 mdavis36 deleted the bugfix/offline-build branch September 22, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

@MishaZakharchanka MishaZakharchanka Awaiting requested review from MishaZakharchanka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdavis36 @jmikeowen