Fixing cmake python build with mpicxx #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l flags even when underlying compiler is not icpc
mdavis36
force-pushed
the
feature/cmake-build-time-tpls
branch
from
b4af9b5 to
eb891db
Compare
jmikeowen
approved these changes
Jun 1, 2020
jmikeowen
pushed a commit
that referenced
this pull request
Aug 14, 2020
* commit 'c2de9176089ed4dd2e17053dee2a1ca219c52db4': Changing from hard-wired python to CMake defined PYTHON_EXE Fixes for the new python source install function. Adding a central cmake function for installing Spheral python source files, and moved byte-compiling the results to that method. This currently results redundant compileall calls, but seems to work. Adding a few new install tasks: byte compile all the installed Spheral python; make a "spheral" symlink to the python executable. Working on add pycompileall for Spheral python, and a spheral symlink.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug when building python with mpicxx, python tries to add intel flags even when underlying compiler is not icpc.