GSPH added more tests #100
Conversation
c=<0 is handled by the riemann solvers now
added GSPH and FSISPH hydros to sedov. Updated CRKSPH and PSPH for some input and name changes
|
This mostly looks good. One question though -- I note in the Sedov test you changed the default for smoothSpike (smoothing the initial energy deposition) from False to True. I'm assuming this is because GSPH doesn't behave well with the more discontinuous initial energy? If that's the case, I might prefer to keep the default value False and add the smoothSpike=True in the ATS test line for GSPH. Almost all of our methods do better with the smoother initial condition, but I consider the pathological energy spike a stress test for the methods. |
|
oh that was actually me just fiddling around giving-in to a curiousity. I meant to put that back as was. I'll put another commit in changing it back. There isn't much of a noticable difference w/ GSPH for the smooth and non-smooth I.C. when running sum density. Using integrate density there is a bit of a difference but it's not huge. |
Check for sound speed greater than zero in GSPH eval derivs was outdated. Low sound speed cases are handled by the riemann solvers now.
Added GSPH to tests:
Noh 3d
Sod gas-gas 1d,2d,3d
Sedov 1d,2d,3d