Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ByteRange::FromEnd to ByteRange::Suffix #86

Merged
merged 4 commits into from
Oct 20, 2024
Merged

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Oct 20, 2024

No codecs would request a footer with an offset, and most stores could not support such an operation without a size request.

  • Add ByteRange::new and From for various RangeBounds<u64> implementors.
  • Remove ByteRange::offset()
  • Add ByteRange::new and From for RangeBounds<u64>

@LDeakin LDeakin added breaking-changes The PR has API changes zarrs_storage labels Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 18 lines in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (6898fe0) to head (86e9add).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
zarrs_storage/src/byte_range.rs 81.39% 8 Missing ⚠️
...ec/bytes_to_bytes/crc32c/crc32c_partial_decoder.rs 0.00% 6 Missing ⚠️
...s/src/array/codec/byte_interval_partial_decoder.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   82.95%   83.01%   +0.05%     
==========================================
  Files         162      162              
  Lines       22500    22486      -14     
==========================================
+ Hits        18665    18666       +1     
+ Misses       3835     3820      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

No codecs would request a footer with an offset, and most stores could not support such an operation without a size request.
@LDeakin LDeakin merged commit a7fe185 into main Oct 20, 2024
22 checks passed
@LDeakin LDeakin deleted the byte_range_suffix branch October 20, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes The PR has API changes zarrs_storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant