Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial encoding support (sync only) #45

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Jul 30, 2024

This is mainly to support incremental writing of large shards similar to the encoding procedure outlined in the sharding specification.

Addresses LDeakin/zarrs_tools#9.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 40.61662% with 443 lines in your changes missing coverage. Please review.

Project coverage is 82.03%. Comparing base (952f543) to head (8277daf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ay/codec/array_to_array_partial_encoder_default.rs 0.00% 72 Missing ⚠️
...s/src/array/codec/array_partial_encoder_default.rs 0.00% 59 Missing ⚠️
...s/src/array/codec/bytes_partial_encoder_default.rs 0.00% 49 Missing ⚠️
...arrs/src/array/codec/array_to_bytes/codec_chain.rs 38.59% 35 Missing ⚠️
...rray_to_bytes/sharding/sharding_partial_encoder.rs 90.90% 18 Missing ⚠️
...ay/codec/array_to_array/bitround/bitround_codec.rs 0.00% 14 Missing ⚠️
.../codec/array_to_array/transpose/transpose_codec.rs 0.00% 14 Missing ⚠️
...rc/array/codec/array_to_bytes/bytes/bytes_codec.rs 0.00% 14 Missing ⚠️
.../array/codec/array_to_bytes/pcodec/pcodec_codec.rs 0.00% 14 Missing ⚠️
.../src/array/codec/array_to_bytes/vlen/vlen_codec.rs 0.00% 14 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   83.10%   82.03%   -1.07%     
==========================================
  Files         162      166       +4     
  Lines       22532    23259     +727     
==========================================
+ Hits        18725    19081     +356     
- Misses       3807     4178     +371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin force-pushed the partial_encoders branch 5 times, most recently from a69de2e to 53e6cd3 Compare August 15, 2024 00:00
@LDeakin LDeakin force-pushed the partial_encoders branch 4 times, most recently from 9b2bedc to c546dd8 Compare September 19, 2024 23:59
@LDeakin LDeakin added enhancement New feature or request breaking-changes The PR has API changes labels Oct 3, 2024
@LDeakin LDeakin force-pushed the partial_encoders branch 8 times, most recently from b428e5e to a6307fe Compare October 5, 2024 11:00
@LDeakin LDeakin removed the breaking-changes The PR has API changes label Oct 5, 2024
@LDeakin LDeakin force-pushed the partial_encoders branch 7 times, most recently from b91e315 to 1491cc4 Compare October 6, 2024 01:54
@LDeakin LDeakin force-pushed the partial_encoders branch 18 times, most recently from 0329f18 to aa2c06f Compare November 1, 2024 00:04
@LDeakin LDeakin changed the title Codec partial encoders Add partial encoding support (sync only) Nov 1, 2024
@LDeakin LDeakin marked this pull request as ready for review November 1, 2024 00:05
@LDeakin LDeakin merged commit db79077 into main Nov 1, 2024
22 checks passed
@LDeakin LDeakin deleted the partial_encoders branch November 1, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant